| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Mon, 12 May 2014 18:48:06 +0200 From: Jean Delvare <jdelvare@...e.de> To: Guenter Roeck <linux@...ck-us.net> Cc: Josef Gajdusek <atx@....name>, lm-sensors@...sensors.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH] drivers/hwmon/emc1403.c: add support for emc1412 Hi Guenter, On Mon, 12 May 2014 08:59:31 -0700, Guenter Roeck wrote: > I only see the adt7462 driver scanning for 0x5c. Guess I'll accept the > address for now; I don't see a good reason not to. sensors-detect also scans it for the SMSC EMC1072, EMC1073 and EMC1074 which we don't support yet. I have no objection to scanning it. > Couple of other questions: > - would it make sense to relax store_hyst to not return ERANGE but use clamp_val > instead ? Yes, I had exactly the same thought when reading the code this morning. > - Currently hyst can be stored for all crit attributes even though there is only > one hyst register. Should we change this to only support writing it for > temp1_crit_hyst ? Yes, that would align this driver with what other drivers do. > - I might convert the driver to use regmap if I find the time. Do you have any > concerns with that ? I know nothing about regmap, so no objection, I simply don't care ;-) -- Jean Delvare SUSE L3 Support -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists