linux-kernel - Re: [PATCH 1/1] net/wireless/ibss.c: replace memcpy by ether_addr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1399918029.9240.19.camel@joe-AO725>
Date:	Mon, 12 May 2014 11:07:09 -0700
From:	Joe Perches <joe@...ches.com>
To:	Fabian Frederick <fabf@...net.be>
Cc:	linux-kernel <linux-kernel@...r.kernel.org>,
	Johannes Berg <johannes@...solutions.net>,
	"John W. Linville" <linville@...driver.com>,
	akpm <akpm@...ux-foundation.org>
Subject: Re: [PATCH 1/1] net/wireless/ibss.c: replace memcpy by
 ether_addr_copy

On Mon, 2014-05-12 at 20:00 +0200, Fabian Frederick wrote:
> On Mon, 12 May 2014 10:50:25 -0700
> Joe Perches <joe@...ches.com> wrote:
> 
> > On Mon, 2014-05-12 at 19:30 +0200, Fabian Frederick wrote:
> > > This patch also fixes some comment checkpatch warnings
> > 
> > Hello Fabian.
> > 
> > For all the patches that replace memcpy(foo, bar, ETH_ALEN)
> > with ether_addr_copy, did you use a tool to verify both
> > arguments are __aligned(2) or did you do the verification
> > visually?
> 
> Hello Joe,
> 
> I only replaced ETH_ALEN/memcpy .
> AFAICS ETH_ALEN is defined 6 ...

The difference here is that both arguments to
ether_addr_copy, like all the is_<foo>_ether_addr
helpers, must be __aligned(2).  memcpy has
no alignment requirement.

Please verify that all these changes are to
__aligned(2) arguments.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/