linux-kernel - Re: [PATCH 1/1] kernel/workqueue.c: pr_warning/pr_warn & printk/pr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1399919357.9240.31.camel@joe-AO725>
Date:	Mon, 12 May 2014 11:29:17 -0700
From:	Joe Perches <joe@...ches.com>
To:	Fabian Frederick <fabf@...net.be>
Cc:	Tejun Heo <tj@...nel.org>,
	linux-kernel <linux-kernel@...r.kernel.org>,
	akpm <akpm@...ux-foundation.org>
Subject: Re: [PATCH 1/1] kernel/workqueue.c: pr_warning/pr_warn &
 printk/pr_info

On Mon, 2014-05-12 at 20:26 +0200, Fabian Frederick wrote:
> On Mon, 12 May 2014 11:21:28 -0700 Joe Perches <joe@...ches.com> wrote:
> > On Mon, 2014-05-12 at 19:56 +0200, Fabian Frederick wrote:
[]
> > > diff --git a/kernel/workqueue.c b/kernel/workqueue.c
[]
> > > @@ -4548,7 +4548,7 @@ void print_worker_info(const char *log_lvl, struct task_struct *task)
> > >  		probe_kernel_read(desc, worker->desc, sizeof(desc) - 1);
> > >  
> > >  	if (fn || name[0] || desc[0]) {
> > > -		printk("%sWorkqueue: %s %pf", log_lvl, name, fn);
> > > +		pr_info("%sWorkqueue: %s %pf", log_lvl, name, fn);
> > 
> > Not correct.
> > 
> > log_lvl already emits the appropriate level
> > and this overrides it with KERN_INFO.
> > 
> > The output will now be incorrect emitting
> > at KERN_INFO followed by an SOH and the
> > desired log level.
>
> Such printk can't be converted to pr_ ?

Correct.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/