linux-kernel - Re: [PATCH] drivers/hwmon/emc1403.c: add support for emc14x2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140512184727.GA9003@roeck-us.net>
Date:	Mon, 12 May 2014 11:47:27 -0700
From:	Guenter Roeck <linux@...ck-us.net>
To:	Jean Delvare <jdelvare@...e.de>
Cc:	Josef Gajdusek <atx@....name>, lm-sensors@...sensors.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drivers/hwmon/emc1403.c: add support for emc14x2

On Mon, May 12, 2014 at 07:03:27PM +0200, Jean Delvare wrote:
> On Mon, 12 May 2014 09:14:15 -0700, Guenter Roeck wrote:
> > On Mon, May 12, 2014 at 02:34:09PM +0200, Josef Gajdusek wrote:
> > >  static const struct i2c_device_id emc1403_idtable[] = {
> > > -	{ "emc1403", 0 },
> > > -	{ "emc1404", 1 },
> > > -	{ "emc1423", 0 },
> > > -	{ "emc1424", 1 },
> > > +	{ "emc1402", emc1402 },
> > > +	{ "emc1403", emc1403 },
> > > +	{ "emc1404", emc1404 },
> > > +	{ "emc1422", emc1402 },
> > > +	{ "emc1423", emc1403 },
> > > +	{ "emc1424", emc1404 },
> > 
> > Wonder if we should list the emc141x chips here. Jean, any thoughts ?
> 
> Yes we should, so that people can declare the right chip in platform
> files, device tree etc. We can map the additional names to existing
> types if the chips are fully compatible.
> 
The chips are not only compatible, the even have the same device IDs.
Maybe I missed it, but I did not find a difference.

I'll add another patch to my list.

Guenter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/