linux-kernel - Re: [PATCH v3 5/8] usb: ehci-platform: add optional reset controller retrieval

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.44L0.1405121604140.1202-100000@iolanthe.rowland.org>
Date:	Mon, 12 May 2014 16:06:16 -0400 (EDT)
From:	Alan Stern <stern@...land.harvard.edu>
To:	Maxime Ripard <maxime.ripard@...e-electrons.com>
cc:	Emilio Lopez <emilio@...pez.com.ar>,
	Mike Turquette <mturquette@...aro.org>, <kishon@...com>,
	<hdegoede@...hat.com>, Boris Brezillon <boris@...e-electrons.com>,
	<linux-kernel@...r.kernel.org>,
	<linux-arm-kernel@...ts.infradead.org>,
	<linux-usb@...r.kernel.org>, <kevin.z.m.zh@...il.com>,
	<sunny@...winnertech.com>, <shuge@...winnertech.com>,
	<zhuzhenhua@...winnertech.com>, <linux-sunxi@...glegroups.com>,
	Boris BREZILLON <boris.brezillon@...e-electrons.com>
Subject: Re: [PATCH v3 5/8] usb: ehci-platform: add optional reset controller
 retrieval

On Mon, 12 May 2014, Maxime Ripard wrote:

> From: Boris BREZILLON <boris.brezillon@...e-electrons.com>
> 
> On the Allwinner's A31 SoC the reset line connected to the EHCI IP has to
> be deasserted for the EHCI block to be usable.
> 
> Add support for an optional reset controller that will be deasserted on
> power off and asserted on power on.
> 
> Signed-off-by: Boris BREZILLON <boris.brezillon@...e-electrons.com>
> Signed-off-by: Maxime Ripard <maxime.ripard@...e-electrons.com>
> Reviewed-by: Hans de Goede <hdegoede@...hat.com>

...

> @@ -208,6 +210,18 @@ static int ehci_platform_probe(struct platform_device *dev)
>  		}
>  	}
>  
> +	priv->rst = devm_reset_control_get_optional(&dev->dev, NULL);
> +	if (IS_ERR(priv->rst)) {
> +		err = PTR_ERR(priv->rst);
> +		if (err == -EPROBE_DEFER)
> +			goto err_put_clks;
> +		priv->rst = NULL;
> +	} else {
> +		err = reset_control_deassert(priv->rst);
> +		if (err)
> +			goto err_put_clks;
> +	}
> +
>  	if (pdata->big_endian_desc)
>  		ehci->big_endian_desc = 1;
>  	if (pdata->big_endian_mmio)

You don't re-assert the reset control if an error happens later on 
during probe.  Was that intentional?

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/