linux-kernel - Re: [PATCH 1/2] FS/CACHEFILES: convert printk to pr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 12 May 2014 13:43:25 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Fabian Frederick <fabf@...net.be>
Cc:	linux-kernel <linux-kernel@...r.kernel.org>,
	David Howells <dhowells@...hat.com>
Subject: Re: [PATCH 1/2] FS/CACHEFILES: convert printk to pr_foo()

On Mon, 12 May 2014 20:04:45 +0200 Fabian Frederick <fabf@...net.be> wrote:

> 
> --- a/fs/cachefiles/bind.c
> +++ b/fs/cachefiles/bind.c
> @@ -228,9 +228,8 @@ static int cachefiles_daemon_add_cache(struct cachefiles_cache *cache)
>  	set_bit(CACHEFILES_READY, &cache->flags);
>  	dput(root);
>  
> -	printk(KERN_INFO "CacheFiles:"
> -	       " File cache on %s registered\n",
> -	       cache->cache.identifier);
> +	pr_info("CacheFiles: File cache on %s registered\n",
> +		cache->cache.identifier);

Why are we using "CacheFiles: " everywhere?  Can't this be done via pr_fmt()?

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/