linux-kernel - Re: [patch 0/3] futex/rtmutex: Fix issues exposed by trinity

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 12 May 2014 17:37:05 -0400
From:	Steven Rostedt <rostedt@...dmis.org>
To:	Thomas Gleixner <tglx@...utronix.de>
Cc:	LKML <linux-kernel@...r.kernel.org>, Dave Jones <davej@...hat.com>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Peter Zijlstra <peterz@...radead.org>,
	Darren Hart <darren@...art.com>,
	Davidlohr Bueso <davidlohr@...com>,
	Ingo Molnar <mingo@...nel.org>,
	Clark Williams <williams@...hat.com>,
	Paul McKenney <paulmck@...ux.vnet.ibm.com>,
	Lai Jiangshan <laijs@...fujitsu.com>,
	Roland McGrath <roland@...k.frob.com>,
	Carlos ODonell <carlos@...hat.com>,
	Jakub Jelinek <jakub@...hat.com>,
	Michael Kerrisk <mtk.manpages@...il.com>,
	Sebastian Andrzej Siewior <bigeasy@...utronix.de>
Subject: Re: [patch 0/3] futex/rtmutex: Fix issues exposed by trinity

On Mon, 12 May 2014 20:45:32 -0000
Thomas Gleixner <tglx@...utronix.de> wrote:

>    Steven, I told you more than once, that your damned performance and
>    feature mania is completely unacceptable.

Yes you have, and now you are yelling at me for something I did 3 years
ago. But this isn't one of my "performance and feature mania" things
you bitched at me about. This is something *you* asked me to look at!

http://marc.info/?l=linux-kernel&m=129242481625261

The "stress test" you recommend back then was just to port it to -rt
and test it there. Which I did, and it found various issues where I
helped Lai fix.

> 
>    When the patch was posted, you were reviewing it. When I wanted to
>    test it, it did not apply and you told me you'll fix it and pick it
>    up. Sure you made it apply and you sticked it into a git tree and
>    let Ingo pull it.
> 
>    I didn't pay much attention as I was happy with the idea in
>    general. I trusted your review and judgement. My problem.
> 
>    Why on earth did you merge that patch even if the changelog mentions
>    that Documentation was left stale and the tester broken?

Sure, I should have pushed Lai for that at the time. Lessons learned. I
was expecting he would do so after we got to a final version of the
patch but I was also working on other things at the time and forgot to
remind him.

I'm surprised you didn't mention to me to make sure the documentation
and test case got fixed before this went further. In fact, that was
never mentioned. These patches went through 4 revisions over a month,
and I even posted another RFC for them to get into the -rt tree.

> 
>    This is beyond sloppy and outright stupid.

Thomas, listen to yourself. You are calling something that got in
without updating the documentation and test case "beyond sloppy and
outright stupid". Sure, I'll agree it was a little sloppy, and today I'm
more on the ball to get things like this right (as we push much harder
today on documentation coming in along with code changes). But the
change log had:

    need updated after this patch is accepted
    1) Document/*
    2) the testcase scripts/rt-tester/t4-l2-pi-deboost.tst

I agree this should be fixed, but you temper tantrum over this seems a
bit over the top.

> 
>    Get this fixed now!
> 
>    And those fixes are not going to be merged without my Reviewed-by.
> 
>    I'm not going to let your multi-reader patches anywhere near RT,
>    unless this Documentation and tester issue is resolved.
> 
>    After that I'm going through them with a fine comb, as I really lost
>    the last modicom of hope, that you can do something without leaving
>    trainwrecks left and right.

And it boils down to this. In the past, I have screwed up where you
were the one (and usually the only one) that got hit by that mess. But
now you seem to take any little mistake done by me as a sign of
complete incompetence.

I'm sorry you feel this way.

I'll try to fix this up as I get a chance (I still have a day job to
do).

-- Steve

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/