linux-kernel - Re: [PATCH 6/8] usb: xhci: avoid warning for !PM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140513195255.GC1151@saruman.home>
Date:	Tue, 13 May 2014 14:52:55 -0500
From:	Felipe Balbi <balbi@...com>
To:	Arnd Bergmann <arnd@...db.de>
CC:	<linux-arm-kernel@...ts.infradead.org>, <balbi@...com>,
	Mathias Nyman <mathias.nyman@...el.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	<linux-usb@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 6/8] usb: xhci: avoid warning for !PM_SLEEP

On Tue, May 13, 2014 at 09:39:37PM +0200, Arnd Bergmann wrote:
> On Tuesday 13 May 2014 10:28:29 Felipe Balbi wrote:
> > > diff --git a/drivers/usb/host/xhci-plat.c b/drivers/usb/host/xhci-plat.c
> > > index 151901c..3473296 100644
> > > --- a/drivers/usb/host/xhci-plat.c
> > > +++ b/drivers/usb/host/xhci-plat.c
> > > @@ -202,7 +202,7 @@ static int xhci_plat_remove(struct platform_device *dev)
> > >       return 0;
> > >  }
> > >  
> > > -#ifdef CONFIG_PM
> > > +#ifdef CONFIG_PM_SLEEP
> > 
> > can we just drop the ifdeferry altogether, including from SET_*_OPS
> > macros ? This is just ridiculous that every merge window we have tens of
> > patches fixing the ifdef in several drivers.
> 
> That would work for me. Another suggestion that came up before was
> to change the SET_*_OPS so that the compiler silently drops the unused
> functions, but unfortunately that would require changing all drivers.

either way would work for me, and such patches would probably be merged
through the trivial tree.

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)