linux-kernel - Re: [PATCH tip/core/rcu 32/45] torture: Better summary diagnostics for build failures

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140513202136.GC2911@cloud>
Date:	Tue, 13 May 2014 13:21:36 -0700
From:	josh@...htriplett.org
To:	"Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>
Cc:	linux-kernel@...r.kernel.org, mingo@...nel.org,
	laijs@...fujitsu.com, dipankar@...ibm.com,
	akpm@...ux-foundation.org, mathieu.desnoyers@...icios.com,
	niv@...ibm.com, tglx@...utronix.de, peterz@...radead.org,
	rostedt@...dmis.org, dhowells@...hat.com, edumazet@...gle.com,
	darren@...art.com, fweisbec@...il.com, oleg@...hat.com, sbw@....edu
Subject: Re: [PATCH tip/core/rcu 32/45] torture: Better summary diagnostics
 for build failures

On Tue, May 13, 2014 at 12:25:54PM -0700, Paul E. McKenney wrote:
> On Sat, May 10, 2014 at 12:34:12PM -0700, Josh Triplett wrote:
> > On Fri, May 09, 2014 at 05:48:38PM -0700, Paul E. McKenney wrote:
> > > On Wed, May 07, 2014 at 03:11:39PM -0700, josh@...htriplett.org wrote:
> > > > On Mon, Apr 28, 2014 at 05:25:20PM -0700, Paul E. McKenney wrote:
> > > > > From: "Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>
> > > > > 
> > > > > The reaction of kvm-recheck.sh is obscure at best, and easy to miss
> > > > > completely.  This commit therefore prints "BUG: Build failed" in the
> > > > > summary at the end of a run.
> > > > 
> > > > This commit also changes a dozen other things about the output that this
> > > > commit message does not document. :)
> > > 
> > > Well, I don't know about a dozen, but I did upgrade the commit message to
> > > read as follows:
> > > 
> > > 	The reaction of kvm-recheck.sh is obscure at best, and easy to
> > > 	miss completely.  This commit therefore prints "BUG: Build failed"
> > > 	in the summary at the end of a run.  This commit also adds the
> > > 	line of dashes in cases where performance info is not available,
> > > 	and also avoids printing nonsense diagnostics in cases where
> > > 	some of the normal test output is not available.
> > 
> > What about the change to kvm-test-1-run.sh?
> 
> Right you are!
> 
> 	The reaction of kvm-recheck.sh is obscure at best, and easy to
> 	miss completely.  This commit therefore prints "BUG: Build failed"
> 	in the summary at the end of a run.  This commit also adds the
> 	line of dashes in cases where performance info is not available,
> 	and also avoids printing nonsense diagnostics in cases where
> 	some of the normal test output is not available.  In addition,
> 	this commit saves off the .config file even when the build fails.

Looks good, ship it.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/