linux-kernel - Re: [PATCH 2/2] FS/CONFIGFS: Use pr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1400020223.24350.73.camel@joe-AO725>
Date:	Tue, 13 May 2014 15:30:23 -0700
From:	Joe Perches <joe@...ches.com>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	Valdis.Kletnieks@...edu, Fabian Frederick <fabf@...net.be>,
	linux-kernel <linux-kernel@...r.kernel.org>,
	Joel Becker <jlbec@...lplan.org>
Subject: Re: [PATCH 2/2] FS/CONFIGFS: Use pr_fmt

On Tue, 2014-05-13 at 15:15 -0700, Andrew Morton wrote:
> On Tue, 13 May 2014 18:06:50 -0400 Valdis.Kletnieks@...edu wrote:
> > On Tue, 13 May 2014 13:50:49 -0700, Andrew Morton said:
> > > On Tue, 13 May 2014 20:24:28 +0200 Fabian Frederick <fabf@...net.be> wrote:
> > 
> > > > +#ifdef pr_fmt
> > > > +#undef pr_fmt
> > > > +#endif
> > >
> > > Why this?
> > >
> > > > +#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
> > 
> > Won't GCC whinge by default about the #define if it doesn't exactly match the
> > previous definition?
> 
> Yes, if there's already a pf_fmt defined.  That's what I'm asking about
> - what pr_fmt are we overriding here?  Seems wrong.

If this is not the first #include or if this
#includes kernel.h/printk.h, then the default
#define pr_fmt(fmt) fmt
from printk.h will be used.

One year soon, I'd like to change the default
from blank to KBUILD_MODNAME ": " fmt


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/