linux-kernel - RE: [PATCH] Documentation/dma-buf-sharing.txt: update API descriptions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <001501cf6f06$9c86f190$d594d4b0$@lge.com>
Date:	Wed, 14 May 2014 08:53:59 +0900
From:	"Gioh Kim" <gioh.kim@....com>
To:	"'Thierry Reding'" <thierry.reding@...il.com>
Cc:	"'Sumit Semwal'" <sumit.semwal@...aro.org>,
	"'Randy Dunlap'" <rdunlap@...radead.org>,
	<linux-media@...r.kernel.org>, <dri-devel@...ts.freedesktop.org>,
	<linux-doc@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	<gunho.lee@....com>
Subject: RE: [PATCH] Documentation/dma-buf-sharing.txt: update API descriptions

Thank you for advice.
I will send a fixed patch soon.

> -----Original Message-----
> From: Thierry Reding [mailto:thierry.reding@...il.com]
> Sent: Tuesday, May 13, 2014 5:45 PM
> To: gioh.kim
> Cc: Sumit Semwal; Randy Dunlap; linux-media@...r.kernel.org; dri-devel@...ts.freedesktop.org; linux-
> doc@...r.kernel.org; linux-kernel@...r.kernel.org; gunho.lee@....com
> Subject: Re: [PATCH] Documentation/dma-buf-sharing.txt: update API descriptions
> 
> On Mon, May 12, 2014 at 08:48:12PM +0900, gioh.kim wrote:
> > From: "gioh.kim" <gioh.kim@....com>
> 
> It might be good to fix your setup to make this be the same as the name
> and email used in the Signed-off-by line below.
> 
> > update some descriptions for API arguments and descriptions.
> 
> Nit: "Update" since it's the beginning of a sentence.
> 
> > Signed-off-by: Gioh Kim <gioh.kim@....com>
> > ---
> >  Documentation/dma-buf-sharing.txt |   10 ++++++----
> >  1 file changed, 6 insertions(+), 4 deletions(-)
> >
> > diff --git a/Documentation/dma-buf-sharing.txt b/Documentation/dma-buf-sharing.txt
> > index 505e711..1ea89b8 100644
> > --- a/Documentation/dma-buf-sharing.txt
> > +++ b/Documentation/dma-buf-sharing.txt
> > @@ -56,7 +56,7 @@ The dma_buf buffer sharing API usage contains the following steps:
> >  				     size_t size, int flags,
> >  				     const char *exp_name)
> >
> > -   If this succeeds, dma_buf_export allocates a dma_buf structure, and returns a
> > +   If this succeeds, dma_buf_export_named allocates a dma_buf structure, and returns a
> 
> Perhaps reformat this so that the lines don't exceed 80 characters?
> 
> >     pointer to the same. It also associates an anonymous file with this buffer,
> >     so it can be exported. On failure to allocate the dma_buf object, it returns
> >     NULL.
> > @@ -66,7 +66,7 @@ The dma_buf buffer sharing API usage contains the following steps:
> >
> >     Exporting modules which do not wish to provide any specific name may use the
> >     helper define 'dma_buf_export()', with the same arguments as above, but
> > -   without the last argument; a __FILE__ pre-processor directive will be
> > +   without the last argument; a KBUILD_MODNAME pre-processor directive will be
> >     inserted in place of 'exp_name' instead.
> 
> This was already fixed in commit 2e33def0339c (dma-buf: update exp_name
> when using dma_buf_export()). Perhaps you should rebase this patch on
> top of the latest linux-next.
> 
> Otherwise looks good.
> 
> Thierry

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/