lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 13 May 2014 10:33:55 +0100 From: Srinivas Kandagatla <srinivas.kandagatla@...aro.org> To: Linus Walleij <linus.walleij@...aro.org> CC: Russell King <linux@....linux.org.uk>, "linux-mmc@...r.kernel.org" <linux-mmc@...r.kernel.org>, Chris Ball <chris@...ntf.net>, Ulf Hansson <ulf.hansson@...aro.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, agross@...cinc.com, "linux-arm-msm@...r.kernel.org" <linux-arm-msm@...r.kernel.org> Subject: Re: [PATCH v1 07/11] mmc: mmci: move ST specific register extensions access under condition. On 13/05/14 09:08, Linus Walleij wrote: >> > /* Keep ST Micro busy mode if enabled */ >> >- datactrl |= host->datactrl_reg & MCI_ST_DPSM_BUSYMODE; >> >+ if (host->hw_designer == AMBA_VENDOR_ST) >> >+ datactrl |= host->datactrl_reg & MCI_ST_DPSM_BUSYMODE; > Do not hard-check the hw_designer everywhere, follow the pattern > if storing special stuff in the variant data. > Got it, I will fix this across other patches too. > struct variant_data { > u32 datactrl_mask_busymode; > (...) > > static struct variant_data variant_u300 = { > .datactrl_mask_busymode = MCI_ST_DPSM_BUSYMODE, > (...) > static struct variant_data variant_nomadik = { -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists