linux-kernel - Re: [PATCH v1 00/11] Add Qualcomm SD Card Controller support.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 13 May 2014 12:04:45 +0200
From:	Ulf Hansson <ulf.hansson@...aro.org>
To:	srinivas.kandagatla@...aro.org
Cc:	Russell King <linux@....linux.org.uk>,
	linux-mmc <linux-mmc@...r.kernel.org>,
	Chris Ball <chris@...ntf.net>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	agross@...cinc.com, linux-arm-msm@...r.kernel.org
Subject: Re: [PATCH v1 00/11] Add Qualcomm SD Card Controller support.

On 29 April 2014 10:18,  <srinivas.kandagatla@...aro.org> wrote:
> From: Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
>
> Hi Russell,
>
> This patch series adds Qualcomm SD Card Controller support in pl180 mmci
> driver. QCom SDCC is basically a pl180, but bit more customized, some of the
> register layouts and offsets are different to the ones mentioned in pl180
> datasheet. The plan is to totally remove the standalone SDCC driver
> drivers/mmc/host/msm_sdcc.* and start using generic mmci driver for all
> Qualcomm parts, as we get chance to test on other Qcom boards.
>
> To start using the existing mmci driver, a fake amba id for Qualcomm is added
> in patches:
>  ARM: amba: Add Qualcomm vendor ID.
>  mmc: mmci: Add Qualcomm Id to amba id table.
>
> Second change is, adding a 3 clock cycle delay for register writes on QCOM
> SDCC
> registers, which is done in patches:
>   mmc: mmci: Add register read/write wrappers.
>   mmc: mmci: Qcomm: Add 3 clock cycle delay after each register write
>
> Third change was to accommodate DATCTRL and MMCICLK register layout changes in
> Qcom SDCC. Which is done in patches:
>   mmc: mmci: Add Qcom datactrl register variant
>   mmc: mmci: Add Qcom variations to MCICommand register.
>   mmc: mmci: Qcom fix MCICLK register settings.
>   mmc: mmci: Add clock support for Qualcomm.
>
> Fourth major change was to add qcom specfic pio read function, the need for
> this is because the way MCIFIFOCNT register behaved in QCOM SDCC is very
>  different to the one in pl180. This change is done in patch:
>   mmc: mmci: Add Qcom specific pio_read function.
>
> Last some Qcom unrelated changes to support Qcom are done in patches:
>   mmc: mmci: use NSEC_PER_SEC macro
>   mmc: mmci: move ST specific register extensions access under condition.
>
> This patches are tested  v3.15-rc3 in PIO mode on IFC6410 board with both eMMC
> and external SD card. I would appreciate any feedback on the patches.
> I would like to get this for v3.16.
>
> Thanks,
> srini
>

Hi Srinivas,

Thanks for working on this patchset, much appreciated! I intend to
review them as soon as I can.

For your information, currently there are one patch queued via Chris'
mmc tree for mmci and recently I have added my quite extensive
patchset, via mine mmc tree, all to be tested in Linux next.

I suppose the best approach to not hit conflicts would be if you base
your patches upon my tree. Potentially we could merge them this way,
unless of course Russell have other opinions.

git://git.linaro.org/people/ulf.hansson/mmc.git next

Kind regards
Ulf Hansson
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/