linux-kernel - Re: sched: fix: initialization of sched_domain

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140513101520.GX30445@twins.programming.kicks-ass.net>
Date:	Tue, 13 May 2014 12:15:20 +0200
From:	Peter Zijlstra <peterz@...radead.org>
To:	Vincent Guittot <vincent.guittot@...aro.org>
Cc:	mingo@...nel.org, jet.chen@...el.com, fengguang.wu@...el.com,
	linux-ia64@...r.kernel.org, linux-s390@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: sched: fix: initialization of sched_domain_topology for NUMA

On Tue, May 13, 2014 at 11:11:01AM +0200, Vincent Guittot wrote:
> Jet Chen has reported a kernel panics when booting qemu-system-x86_64 with
> kvm64 cpu. A panic occured while building the sched_domain.
> 
> In sched_init_numa, we create a new topology table in which both default
> levels and numa levels are copied. The last row of the table must have a null
> pointer in the mask field.
> 
> The current implementation doesn't add this last row in the computation of the
> table size. So we add 1 row in the allocation size that will be used as the
> last row of the table. The kzalloc will ensure that the mask field is NULL.
> 
> Reported-by: Jet Chen <jet.chen@...el.com>
> Tested-by: Jet Chen <jet.chen@...el.com>
> Signed-off-by: Vincent Guittot <vincent.guittot@...aro.org>
> link: https://lkml.org/lkml/2014/5/12/130
> 
> ---
> 
> Hi Peter,
> 
> Does this commit message contain enough information ?

Yes, thanks!

Content of type "application/pgp-signature" skipped