| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Tue, 13 May 2014 14:07:51 +0200 From: Antoine Ténart <antoine.tenart@...e-electrons.com> To: Andrew Lunn <andrew@...n.ch> Cc: Antoine Ténart <antoine.tenart@...e-electrons.com>, sebastian.hesselbarth@...il.com, tj@...nel.org, thomas.petazzoni@...e-electrons.com, zmxu@...vell.com, linux-kernel@...r.kernel.org, linux-ide@...r.kernel.org, alexandre.belloni@...e-electrons.com, jszhang@...vell.com, linux-arm-kernel@...ts.infradead.org Subject: Re: [PATCH v2 3/6] ata: ahci: add AHCI support for the Berlin BG2Q Hi Andrew, On Mon, May 12, 2014 at 04:12:21PM +0200, Andrew Lunn wrote: > On Mon, May 12, 2014 at 11:16:54AM +0200, Antoine Ténart wrote: […] > I've no idea is this is a good or bad idea, but could you put all the > above code in the phy driver? It does seem to be mostly phy > related. Then teach the core ahci code about optional phy nodes in DT. > You can then probably do without a ahci berlin driver. The code is PHY related, but the setup done is SATA specific. I think it makes sense to keep it here. From what I saw lots of PHY drivers only power up / down the PHYs. Lots of port setups are done in the SATA framework, so it would separate related code into two subsystems. Antoine -- Antoine Ténart, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists