linux-kernel - Re: [Patch V2 0/9] I2C ACPI operation region handler support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3275231.ERSr3mUlis@devpool02>
Date:	Tue, 13 May 2014 15:09:05 +0200
From:	Rolf Eike Beer <eb@...ix.com>
To:	Lan Tianyu <tianyu.lan@...el.com>
Cc:	wsa@...-dreams.de, rjw@...ysocki.net,
	mika.westerberg@...ux.intel.com, awilliam@...hat.com,
	lenb@...nel.org, linux-i2c@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-acpi@...r.kernel.org
Subject: Re: [Patch V2 0/9] I2C ACPI operation region handler support

Am Montag, 28. April 2014, 22:27:39 schrieb Lan Tianyu:
> ACPI 5.0 spec(5.5.2.4.5) defines GenericSerialBus(i2c, spi, uart) operation
> region. It allows ACPI aml code able to access such kind of devices to
> implement some ACPI standard method.
> 
> On the Asus T100TA, Bios use GenericSerialBus operation region to access
> i2c device to get battery info. So battery function depends on the I2C
> operation region support. Here is the bug link.
> https://bugzilla.kernel.org/show_bug.cgi?id=69011

Hi all,

I have tested this series and got some errors, but no additional functionality:

[    0.607442] ACPI Error: Error attaching device[f60238a0] data
[    0.607460]  (20140214/bus-143)
[    0.607708] ACPI Error: Error attaching device[f60238a0] data
[    0.607724]  (20140214/bus-143)
[    0.607987] ACPI Error: Error attaching device[f60238a0] data
[    0.608003]  (20140214/bus-143)
[    0.608251] ACPI Error: Error attaching device[f60238a0] data
[    0.608267]  (20140214/bus-143)
[    0.608515] ACPI Error: Error attaching device[f60238a0] data
[    0.608531]  (20140214/bus-143)

A bit more output, e.g. the error code if such is present or the device path,
could probably help when identifyint the device in question.

Also this still looks incomplete, as on other places one still gets those
warnings:

[    0.314944] pnp 00:08: Plug and Play ACPI device, IDs INT33fc (active)
[    0.316122] pnp 00:09: unknown resource type 19 in _CRS
[    0.316136] pnp 00:09: can't evaluate _CRS: 1

I don't know if looking on them at this place has any value, maybe something
like this is correct?

commit 52e2822c4c8b09180e5eb3dd94e4e9aea0d25eff
Author: Rolf Eike Beer <eb@...ix.com>
Date:   Tue Feb 18 11:11:10 2014 +0100

    ACPI: ignore GPIO and SERIAL_BUS resources in PNP init code

diff --git a/drivers/pnp/pnpacpi/rsparser.c b/drivers/pnp/pnpacpi/rsparser.c
index 167f3d0..5b8459b 100644
--- a/drivers/pnp/pnpacpi/rsparser.c
+++ b/drivers/pnp/pnpacpi/rsparser.c
@@ -240,6 +240,8 @@ static acpi_status pnpacpi_allocated_resource(struct acpi_resource *res,
                break;
 
        case ACPI_RESOURCE_TYPE_GENERIC_REGISTER:
+       case ACPI_RESOURCE_TYPE_GPIO:
+       case ACPI_RESOURCE_TYPE_SERIAL_BUS:
                break;
 
        default:

Greetings,

Eike
-- 
Rolf Eike Beer, emlix GmbH, http://www.emlix.com
Fon +49 551 30664-0, Fax +49 551 30664-11
Bertha-von-Suttner-Str. 9, 37085 Göttingen, Germany
Sitz der Gesellschaft: Göttingen, Amtsgericht Göttingen HR B 3160
Geschäftsführung: Dr. Uwe Kracke, Ust-IdNr.: DE 205 198 055

emlix - smart embedded open source

Download attachment "signature.asc" of type "application/pgp-signature" (317 bytes)