linux-kernel - Re: [PATCH 5/7] irqchip: s3c24xx: fix function type for IRQCHIP_OF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 13 May 2014 12:02:06 -0500
From:	Rob Herring <robherring2@...il.com>
To:	Jason Cooper <jason@...edaemon.net>
Cc:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	Thomas Gleixner <tglx@...utronix.de>
Subject: Re: [PATCH 5/7] irqchip: s3c24xx: fix function type for IRQCHIP_OF_DECLARE

On Tue, May 13, 2014 at 10:22 AM, Jason Cooper <jason@...edaemon.net> wrote:
> Rob,
>
> On Mon, May 12, 2014 at 07:29:51PM -0500, Rob Herring wrote:
>> From: Rob Herring <robh@...nel.org>
>>
>> Adding function type checking to IRQCHIP_OF_DECLARE found a type mismatch
>> with s3c2410_init_intc_of and s3c2416_init_intc_of. The function only takes
>> the 1st 2 parameters.
>>
>> Signed-off-by: Rob Herring <robh@...nel.org>
>> Cc: Thomas Gleixner <tglx@...utronix.de>
>> ---
>>  drivers/irqchip/irq-s3c24xx.c | 6 ++----
>>  1 file changed, 2 insertions(+), 4 deletions(-)
>
> Thomas has asked me to give him a hand with the patches for
> drivers/irqchip.  When you add these two to your tree, could you amend
> the subject line to conform with the other patches in that directory?

Excellent! We've needed some help there for a long time. Is there a
patch in flight to add this to MAINTAINERS.

> eg (note the capitalization on 'Fix'):
>
>   irqchip: s3c24xx: Fix function type for IRQCHIP_OF_DECLARE
>   irqchip: mxs: Fix function type for IRQCHIP_OF_DECLARE

Will do.

>
> With that change,
>
> Acked-by: Jason Cooper <jason@...edaemon.net>
>
> Or, if you like, I can apply these two to the branch I'm staging for
> Thomas.  Either is fine with me.
>
> thx,
>
> Jason.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/