linux-kernel - Re: [PATCH V2] fs/cifs/netmisc.c: convert printk to pr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 13 May 2014 20:52:10 +0200
From:	Steve French <smfrench@...il.com>
To:	Fabian Frederick <fabf@...net.be>
Cc:	linux-kernel <linux-kernel@...r.kernel.org>,
	akpm <akpm@...ux-foundation.org>, Joe Perches <joe@...ches.com>
Subject: Re: [PATCH V2] fs/cifs/netmisc.c: convert printk to pr_foo()

merged into cifs-2.6.git

On Tue, May 13, 2014 at 7:30 PM, Fabian Frederick <fabf@...net.be> wrote:
> Also fixes array checkpatch warning and converts it to static const
> (suggested by Joe Perches).
>
> Cc: Joe Perches <joe@...ches.com>
> Cc: Steve French <sfrench@...ba.org>
> Cc: Andrew Morton <akpm@...ux-foundation.org>
> Signed-off-by: Fabian Frederick <fabf@...net.be>
> ---
> v2: static const array (suggested by Joe Perches)
>
>  fs/cifs/netmisc.c | 9 +++++----
>  1 file changed, 5 insertions(+), 4 deletions(-)
>
> diff --git a/fs/cifs/netmisc.c b/fs/cifs/netmisc.c
> index 0498845..6834b9c 100644
> --- a/fs/cifs/netmisc.c
> +++ b/fs/cifs/netmisc.c
> @@ -795,8 +795,8 @@ cifs_print_status(__u32 status_code)
>         while (nt_errs[idx].nt_errstr != NULL) {
>                 if (((nt_errs[idx].nt_errcode) & 0xFFFFFF) ==
>                     (status_code & 0xFFFFFF)) {
> -                       printk(KERN_NOTICE "Status code returned 0x%08x %s\n",
> -                                  status_code, nt_errs[idx].nt_errstr);
> +                       pr_notice("Status code returned 0x%08x %s\n",
> +                                 status_code, nt_errs[idx].nt_errstr);
>                 }
>                 idx++;
>         }
> @@ -941,8 +941,9 @@ cifs_UnixTimeToNT(struct timespec t)
>         return (u64) t.tv_sec * 10000000 + t.tv_nsec/100 + NTFS_TIME_OFFSET;
>  }
>
> -static int total_days_of_prev_months[] =
> -{0, 31, 59, 90, 120, 151, 181, 212, 243, 273, 304, 334};
> +static const int total_days_of_prev_months[] = {
> +       0, 31, 59, 90, 120, 151, 181, 212, 243, 273, 304, 334
> +};
>
>  struct timespec cnvrtDosUnixTm(__le16 le_date, __le16 le_time, int offset)
>  {
> --
> 1.8.4.5
>



-- 
Thanks,

Steve
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/