linux-kernel - Re: [PATCH 1/3] FS/CODA: replace printk by pr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1400008392.24350.52.camel@joe-AO725>
Date:	Tue, 13 May 2014 12:13:12 -0700
From:	Joe Perches <joe@...ches.com>
To:	Jan Harkes <jaharkes@...cmu.edu>
Cc:	Fabian Frederick <fabf@...net.be>,
	linux-kernel <linux-kernel@...r.kernel.org>,
	akpm <akpm@...ux-foundation.org>
Subject: Re: [PATCH 1/3] FS/CODA: replace printk by pr_foo()

On Tue, 2014-05-13 at 14:16 -0400, Jan Harkes wrote:
> On Tue, May 13, 2014 at 06:49:09PM +0200, Fabian Frederick wrote:
> > No level printk converted to pr_warn or pr_info
> > 
> > Cc: Jan Harkes <jaharkes@...cmu.edu>
> > Cc: Andrew Morton <akpm@...ux-foundation.org>
> > Signed-off-by: Fabian Frederick <fabf@...net.be>
> > ---
> 
> Ack, those are nice cleanups for those ugly printk's. Looks like it will
> shave off a few KB of memory too by making the strings shorter.

No.  It doesn't really.

pr_fmt prefaces the format strings with the same
content so there's no actual reduction.

One year soon, I could submit a patch that adds
a generic mechanism to printk which would get the
module name (and function name too) from kallsyms
when pr_fmt is #defined as
	#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
and it's actually compiled as a module.

That would reduce the format string lengths.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/