linux-kernel - Re: [PATCH v8 1/2] phy: Add new Exynos5 USB 3.0 PHY driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAFp+6iH-bLd9WUYyK8d8i=UNUm4DHpEYz=Am_qzPyX6gDovyKA@mail.gmail.com>
Date:	Tue, 13 May 2014 11:37:04 +0530
From:	Vivek Gautam <gautam.vivek@...sung.com>
To:	Kishon Vijay Abraham I <kishon@...com>
Cc:	Linux USB Mailing List <linux-usb@...r.kernel.org>,
	"linux-samsung-soc@...r.kernel.org" 
	<linux-samsung-soc@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>, linux-doc@...r.kernel.org,
	Greg KH <gregkh@...uxfoundation.org>,
	Mark Rutland <mark.rutland@....com>,
	"robh+dt" <robh+dt@...nel.org>, Felipe Balbi <balbi@...com>,
	Kukjin Kim <kgene.kim@...sung.com>,
	Tomasz Figa <t.figa@...sung.com>,
	Sylwester Nawrocki <sylvester.nawrocki@...il.com>,
	Kamil Debski <k.debski@...sung.com>,
	Jingoo Han <jg1.han@...sung.com>
Subject: Re: [PATCH v8 1/2] phy: Add new Exynos5 USB 3.0 PHY driver

Hi Kishon,


On Mon, May 12, 2014 at 6:33 PM, Kishon Vijay Abraham I <kishon@...com> wrote:
> Hi Gautam,
>
> On Friday 09 May 2014 07:27 PM, Vivek Gautam wrote:
>> Add a new driver for the USB 3.0 PHY on Exynos5 series of SoCs.
>> The new driver uses the generic PHY framework and will interact
>> with DWC3 controller present on Exynos5 series of SoCs.
>>
>> Also, created a new header file in linux/mfd/syscon/ for
>> Exynos5 SoCs and put the required PMU offset definitions
>> for the basic available PHYs.
>>
>
>
> I get the following checkpatch warnings
>
> WARNING: please write a paragraph that describes the config symbol fully
> #163: FILE: drivers/phy/Kconfig:163:
> +config PHY_EXYNOS5_USBDRD
>
> WARNING: DT compatible string "samsung,exynos5250-usbdrd-phy" appears
> un-documented -- check ./Documentation/devicetree/bindings/
> #708: FILE: drivers/phy/phy-exynos5-usbdrd.c:516:
> +               .compatible = "samsung,exynos5250-usbdrd-phy",
>
> WARNING: DT compatible string "samsung,exynos5420-usbdrd-phy" appears
> un-documented -- check ./Documentation/devicetree/bindings/
> #711: FILE: drivers/phy/phy-exynos5-usbdrd.c:519:
> +               .compatible = "samsung,exynos5420-usbdrd-phy",.
>
>
> I think you just need to separate the Documentation into a separate patch
> before applying the driver patch.
>

I somehow don't see the Documentation warning. Below is the checkpatch
output which i ran on this v8 patch version.
  linux-phy$ ./scripts/checkpatch.pl phy.patch
  WARNING: please write a paragraph that describes the config symbol fully
  #127: FILE: drivers/phy/Kconfig:163:
  +config PHY_EXYNOS5_USBDRD

  total: 0 errors, 1 warnings, 760 lines checked

  phy.patch has style problems, please review.

  If any of these errors are false positives, please report
  them to the maintainer, see CHECKPATCH in MAINTAINERS.

am i missing something ?

[snip]



-- 
Best Regards
Vivek Gautam
Samsung R&D Institute, Bangalore
India
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/