linux-kernel - Re: [PATCH RESEND v4 3/8] phy: sunxi: Rework phy initialization

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140514064954.GF29258@lukather>
Date:	Wed, 14 May 2014 08:49:54 +0200
From:	Maxime Ripard <maxime.ripard@...e-electrons.com>
To:	Kishon Vijay Abraham I <kishon@...com>
Cc:	Emilio Lopez <emilio@...pez.com.ar>,
	Mike Turquette <mturquette@...aro.org>,
	stern@...land.harvard.edu, hdegoede@...hat.com,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Boris Brezillon <boris@...e-electrons.com>,
	linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	linux-usb@...r.kernel.org, kevin.z.m.zh@...il.com,
	sunny@...winnertech.com, shuge@...winnertech.com,
	zhuzhenhua@...winnertech.com, linux-sunxi@...glegroups.com
Subject: Re: [PATCH RESEND v4 3/8] phy: sunxi: Rework phy initialization

On Wed, May 14, 2014 at 11:18:51AM +0530, Kishon Vijay Abraham I wrote:
> Hi,
> 
> On Tuesday 13 May 2014 09:14 PM, Maxime Ripard wrote:
> > Move the phy initialization and variables declaration to the loop itself, since
> > it is where it really belongs. Also remove all the temporary variables, we can
> > use the structure members directly.
> > 
> > Signed-off-by: Maxime Ripard <maxime.ripard@...e-electrons.com>
> > Reviewed-by: Hans de Goede <hdegoede@...hat.com>
> 
> let me know if I have to queue this and the next patch in my PHY tree.

Yes, that would be great

Thanks,
Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)