linux-kernel - RE: [PATCH] ARM: remove redundant code in machine

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9034CBD80F070943B59700D7F8149ED9A0875745@SC-VEXCH4.marvell.com>
Date:	Wed, 14 May 2014 00:51:34 -0700
From:	Neil Zhang <zhangwm@...vell.com>
To:	Neil Zhang <zhangwm@...vell.com>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
CC:	"rmk+kernel@....linux.org.uk" <rmk+kernel@....linux.org.uk>
Subject: RE: [PATCH] ARM: remove redundant code in machine_halt

> -----Original Message-----
> From: Neil Zhang [mailto:zhangwm@...vell.com]
> Sent: 2014年5月7日 13:50
> To: linux-arm-kernel@...ts.infradead.org; linux-kernel@...r.kernel.org
> Cc: rmk+kernel@....linux.org.uk; Neil Zhang
> Subject: [PATCH] ARM: remove redundant code in machine_halt
> 
> There is no need to call local_irq_disable twice.
> 
> Signed-off-by: Neil Zhang <zhangwm@...vell.com>
> ---
>  arch/arm/kernel/process.c |    1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/arch/arm/kernel/process.c b/arch/arm/kernel/process.c index
> 81ef686..18cfce4 100644
> --- a/arch/arm/kernel/process.c
> +++ b/arch/arm/kernel/process.c
> @@ -195,7 +195,6 @@ void machine_halt(void)
>  	local_irq_disable();
>  	smp_send_stop();
> 
> -	local_irq_disable();
>  	while (1);
>  }
> 
> --
> 1.7.9.5

Any comments?

Best Regards,
Neil Zhang