linux-kernel - Re: [PATCH] pwm: lpss: remove dependency on clk framework

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140514083929.GA12238@xps8300>
Date:	Wed, 14 May 2014 11:39:29 +0300
From:	Heikki Krogerus <heikki.krogerus@...ux.intel.com>
To:	"Chew, Chiau Ee" <chiau.ee.chew@...el.com>
Cc:	Thierry Reding <thierry.reding@...il.com>,
	Mika Westerberg <mika.westerberg@...ux.intel.com>,
	Alan Cox <alan@...ux.intel.com>,
	"linux-pwm@...r.kernel.org" <linux-pwm@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] pwm: lpss: remove dependency on clk framework

Hi,

On Wed, May 14, 2014 at 07:00:59AM +0000, Chew, Chiau Ee wrote:
> Heikki,
> For ACPI mode, the clock rate information for PWM is being setup in the acpi_lpss.c layer.
> Thus, only PCI mode depends on the driver_data to pass in the clock rate information.

The goal with this patch is actually to free acpi_lpss.c from
delivering the clock for this driver.

The LPSS PWM does not get it's clock from the LPSS 100Mhz source
clock, which means we have to have the rate of it's clock hard-coded.
Since it's already hard coded also in this driver for PCI mode in any
case, it makes no sense to also have it there.

So this patch will allow us to cleanup acpi_lpss.c. We can now remove
the confusing "shared clock" structure where the hard coded rates are
held. This device is the only one that would need it.

Thanks,

-- 
heikki
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/