linux-kernel - Re: [PATCH V2 1/2] fs: include device name in error messages about freezing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140514111048.GA5824@quack.suse.cz>
Date:	Wed, 14 May 2014 13:10:48 +0200
From:	Jan Kara <jack@...e.cz>
To:	Mateusz Guzik <mguzik@...hat.com>
Cc:	linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org,
	Josef Bacik <jbacik@...com>, Jan Kara <jack@...e.cz>,
	Al Viro <viro@...IV.linux.org.uk>,
	Eric Sandeen <esandeen@...hat.com>
Subject: Re: [PATCH V2 1/2] fs: include device name in error messages about
 freezing

On Wed 14-05-14 00:04:42, Mateusz Guzik wrote:
> While here use pr_err instead of printk(KERN_ERR...)
  The patch looks good. Just one nit below:

> Signed-off-by: Mateusz Guzik <mguzik@...hat.com>
> Cc: linux-fsdevel@...r.kernel.org
> Cc: Josef Bacik <jbacik@...com>
> Cc: Jan Kara <jack@...e.cz>
> Cc: Al Viro <viro@...IV.linux.org.uk>
> Cc: Eric Sandeen <esandeen@...hat.com>
> ---
>  fs/super.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/fs/super.c b/fs/super.c
> index 48377f7..017e10a 100644
> --- a/fs/super.c
> +++ b/fs/super.c
> @@ -1323,8 +1323,7 @@ int freeze_super(struct super_block *sb)
>  	if (sb->s_op->freeze_fs) {
>  		ret = sb->s_op->freeze_fs(sb);
>  		if (ret) {
> -			printk(KERN_ERR
> -				"VFS:Filesystem freeze failed\n");
> +			pr_err("VFS:Filesystem %s freeze failed\n", sb->s_id);
  I'd somewhat prefer to have the format like:
VFS (device %s): Filesystem freeze failed\n

  That should easy to programatically parse if necessary and also more
consistent with how filesystems report errors. Now VFS itself doesn't have
any unified style but still...

								Honza

>  			sb->s_writers.frozen = SB_UNFROZEN;
>  			smp_wmb();
>  			wake_up(&sb->s_writers.wait_unfrozen);
> @@ -1364,8 +1363,7 @@ int thaw_super(struct super_block *sb)
>  	if (sb->s_op->unfreeze_fs) {
>  		error = sb->s_op->unfreeze_fs(sb);
>  		if (error) {
> -			printk(KERN_ERR
> -				"VFS:Filesystem thaw failed\n");
> +			pr_err("VFS:Filesystem %s thaw failed\n", sb->s_id);
>  			up_write(&sb->s_umount);
>  			return error;
>  		}
> -- 
> 1.8.3.1
> 
-- 
Jan Kara <jack@...e.cz>
SUSE Labs, CR
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/