linux-kernel - Re: [patch] usb: phy: msm: devm_ioremap() doesn't return ERR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <53736EA4.8040203@cogentembedded.com>
Date:	Wed, 14 May 2014 17:24:52 +0400
From:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:	Dan Carpenter <dan.carpenter@...cle.com>,
	Felipe Balbi <balbi@...com>
CC:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Grant Likely <grant.likely@...aro.org>,
	Rob Herring <robh+dt@...nel.org>, linux-usb@...r.kernel.org,
	linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
	kernel-janitors@...r.kernel.org
Subject: Re: [patch] usb: phy: msm: devm_ioremap() doesn't return ERR_PTRs

Hello.

On 14-05-2014 16:55, Dan Carpenter wrote:

> devm_ioremap() returns a NULL on error so the IS_ERR() check needs to be
> updated.

> Fixes: 6b99c68ec1f9 ('usb: phy: msm: Migrate to Managed Device Resource allocation')
> Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>

> diff --git a/drivers/usb/phy/phy-msm-usb.c b/drivers/usb/phy/phy-msm-usb.c
> index c522c4f..bd32257 100644
> --- a/drivers/usb/phy/phy-msm-usb.c
> +++ b/drivers/usb/phy/phy-msm-usb.c
> @@ -1587,8 +1587,8 @@ static int msm_otg_probe(struct platform_device *pdev)
>
>   	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);

    Hm, 'res' can be NULL too, why this isn't checked?

>   	motg->regs = devm_ioremap(&pdev->dev, res->start, resource_size(res));
> -	if (IS_ERR(motg->regs))
> -		return PTR_ERR(motg->regs);
> +	if (!motg->regs)
> +		return -ENOMEM;
>
>   	/*
>   	 * NOTE: The PHYs can be multiplexed between the chipidea controller

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/