linux-kernel - Re: [PATCH] lib: devres: Mark devm_request_and

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140514143043.GC17301@kroah.com>
Date:	Wed, 14 May 2014 16:30:43 +0200
From:	'Greg Kroah-Hartman' <gregkh@...uxfoundation.org>
To:	Jingoo Han <jg1.han@...sung.com>
Cc:	linux-kernel@...r.kernel.org,
	'Florian Fainelli' <f.fainelli@...il.com>,
	'Thierry Reding' <thierry.reding@...il.com>,
	'Joe Perches' <joe@...ches.com>,
	'Dan Carpenter' <dan.carpenter@...cle.com>
Subject: Re: [PATCH] lib: devres: Mark devm_request_and_ioremap() as
 deprecated

On Wed, May 14, 2014 at 02:38:11PM +0900, Jingoo Han wrote:
> devm_request_and_ioremap() was obsoleted by devm_ioremap_resource().
> (7509657 "lib: devres: Introduce devm_ioremap_resource()") So,
> let's mark it as deprecated in order to stop using it.
> 
> Suggested-by: Florian Fainelli <f.fainelli@...il.com>
> Signed-off-by: Jingoo Han <jg1.han@...sung.com>
> Cc: Thierry Reding <thierry.reding@...il.com>
> ---
>  include/linux/device.h |    4 ++--
>  lib/devres.c           |    1 +
>  2 files changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/include/linux/device.h b/include/linux/device.h
> index 67f003a..769c86b 100644
> --- a/include/linux/device.h
> +++ b/include/linux/device.h
> @@ -627,8 +627,8 @@ extern void *devm_kmemdup(struct device *dev, const void *src, size_t len,
>  			  gfp_t gfp);
>  
>  void __iomem *devm_ioremap_resource(struct device *dev, struct resource *res);
> -void __iomem *devm_request_and_ioremap(struct device *dev,
> -			struct resource *res);
> +void __deprecated __iomem *devm_request_and_ioremap(struct device *dev,
> +						    struct resource *res);

If no one uses it, just delete it entirely from the tree, no need to
mark __deprecated, that's not going to stop new people from using it.

Also, I see a number of existing users in Linus's tree, please remove
those usages as well.

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/