linux-kernel - Re: [PATCH v3] gcov: add support for GCC 4.9

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87lhu53ux3.fsf@tassilo.jf.intel.com>
Date:	Tue, 13 May 2014 20:23:36 -0700
From:	Andi Kleen <andi@...stfloor.org>
To:	"Yuan Pengfei" <yuanpf12@....pku.edu.cn>
Cc:	"'Andrew Morton'" <akpm@...ux-foundation.org>,
	"'Peter Oberparleiter'" <oberpar@...ux.vnet.ibm.com>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3] gcov: add support for GCC 4.9

"Yuan Pengfei" <yuanpf12@....pku.edu.cn> writes:

> This patch handles the gcov-related changes in GCC 4.9:
>   A new counter (time profile) is added. The total number is 9 now.
>   A new profile merge function __gcov_merge_time_profile is added.
> See gcc/gcov-io.h and libgcc/libgcov-merge.c
> For the first change, the layout of struct gcov_info is affected.
> For the second one, a dummy function is added to kernel/gcov/base.c
> similarly.


Thanks for doing that. I tried it too at some point, but failed.
>  
> +void __gcov_merge_time_profile(gcov_type *counters, unsigned int
> n_counters)

But can you repost please without word wrapping?

Except for that the patch looks good to me.

-Andi

-- 
ak@...ux.intel.com -- Speaking for myself only
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/