linux-kernel - [PATCH] mm/memory-failure.c: fix memory leak by race between poison and unpoison

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <1400080891-5145-1-git-send-email-n-horiguchi@ah.jp.nec.com>
Date:	Wed, 14 May 2014 11:21:31 -0400
From:	Naoya Horiguchi <n-horiguchi@...jp.nec.com>
To:	Andrew Morton <akpm@...ux-foundation.org>,
	Andi Kleen <andi@...stfloor.org>
Cc:	Wu Fengguang <fengguang.wu@...el.com>,
	linux-kernel@...r.kernel.org, linux-mm@...ck.org
Subject: [PATCH] mm/memory-failure.c: fix memory leak by race between poison and unpoison

When a memory error happens on an in-use page or (free and in-use) hugepage,
the victim page is isolated with its refcount set to one. When you try to
unpoison it later, unpoison_memory() calls put_page() for it twice in order to
bring the page back to free page pool (buddy or free hugepage list.)
However, if another memory error occurs on the page which we are unpoisoning,
memory_failure() returns without releasing the refcount which was incremented
in the same call at first, which results in memory leak and unconsistent
num_poisoned_pages statistics. This patch fixes it.

Signed-off-by: Naoya Horiguchi <n-horiguchi@...jp.nec.com>
Cc: <stable@...r.kernel.org>    [2.6.32+]
---
 mm/memory-failure.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git next-20140512.orig/mm/memory-failure.c next-20140512/mm/memory-failure.c
index 9872af1b1e9d..93a08bd78c78 100644
--- next-20140512.orig/mm/memory-failure.c
+++ next-20140512/mm/memory-failure.c
@@ -1153,6 +1153,8 @@ int memory_failure(unsigned long pfn, int trapno, int flags)
 	 */
 	if (!PageHWPoison(p)) {
 		printk(KERN_ERR "MCE %#lx: just unpoisoned\n", pfn);
+		atomic_long_sub(nr_pages, &num_poisoned_pages);
+		put_page(hpage);
 		res = 0;
 		goto out;
 	}
-- 
1.9.0

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/