lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 14 May 2014 19:13:21 +0200 From: Borislav Petkov <bp@...en8.de> To: Tomasz Nowicki <tomasz.nowicki@...aro.org> Cc: rjw@...ysocki.net, lenb@...nel.org, tony.luck@...el.com, bp@...e.de, m.chehab@...sung.com, linux-edac@...r.kernel.org, x86@...nel.org, linux-acpi@...r.kernel.org, linux-kernel@...r.kernel.org, linaro-acpi@...ts.linaro.org Subject: Re: [PATCH 7/7] acpi, apei, ghes: Factor out ioremap virtual memory for IRQ and NMI context. On Wed, Apr 09, 2014 at 05:14:35PM +0200, Tomasz Nowicki wrote: > @@ -310,6 +310,8 @@ static void ghes_copy_tofrom_phys(void *buffer, u64 paddr, u32 len, > u64 offset; > u32 trunk; > > + BUG_ON(in_nmi && !IS_ENABLED(CONFIG_ACPI_APEI_NMI)); > + That's a good idea but it should be in the NMI notifier ghes_notify_nmi() instead and simpler: BUG_ON(!IS_ENABLED(CONFIG_ACPI_APEI_NMI)); > while (len > 0) { > offset = paddr - (paddr & PAGE_MASK); > if (in_nmi) { -- Regards/Gruss, Boris. Sent from a fat crate under my desk. Formatting is fine. -- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists