linux-kernel - Re: [PATCH] staging: usbip: Fix bad fuction definitions in usbip

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140514193530.GC8897@mwanda>
Date:	Wed, 14 May 2014 22:35:30 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	Pawel Lebioda <pawel.lebioda89@...il.com>
Cc:	gregkh@...uxfoundation.org, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: usbip: Fix bad fuction definitions in usbip

On Wed, May 14, 2014 at 09:28:27PM +0200, Pawel Lebioda wrote:
> Fix bad function definitions in all files from drivers/staging/usbip directory
> 
> Signed-off-by: Pawel Lebioda <pawel.lebioda89@...il.com>

This is fine, but next time try to be more specific in the subject and
also in the changelog.  Put the sparse warning in the changelog.  Say
that you are adding "void".

Btw, the reason for the void is because if it's not void then the
compiler won't complain if you pass a parameter to it.

void frob()
{
	printf("foo\n");
}

int main(void)
{
	frob(1, 2, 3);

	return 0;
}

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/