linux-kernel - Re: [PATCH 1/3] sched: Make sched_setattr() correctly return -EFBIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5372E1C6.5070109@gmail.com>
Date:	Wed, 14 May 2014 05:23:50 +0200
From:	"Michael Kerrisk (man-pages)" <mtk.manpages@...il.com>
To:	Peter Zijlstra <peterz@...radead.org>
CC:	mtk.manpages@...il.com, lkml <linux-kernel@...r.kernel.org>,
	Juri Lelli <juri.lelli@...il.com>,
	Dario Faggioli <raistlin@...ux.it>,
	Ingo Molnar <mingo@...nel.org>,
	"linux-man@...r.kernel.org" <linux-man@...r.kernel.org>
Subject: Re: [PATCH 1/3] sched: Make sched_setattr() correctly return -EFBIG

Peter,

In the title of this patch, EFBIG should have been E2BIG. Shall
I resubmit a corrected version?

Cheers,

Michael

On 05/09/2014 04:54 PM, Michael Kerrisk (man-pages) wrote:
> From: Michael Kerrisk <mtk.manpages@...il.com>
> 
> The documented[1] behavior of sched_attr() in your proposed man page text is:
> 
>     sched_attr::size must be set to the size of the structure, as in
>     sizeof(struct sched_attr), if the provided structure is smaller
>     than the kernel structure, any additional fields are assumed
>     '0'. If the provided structure is larger than the kernel structure,
>     the kernel verifies all additional fields are '0' if not the
>     syscall will fail with -E2BIG.
> 
> As currently implemented, sched_copy_attr() returns -EFBIG for
> for this case, but the logic in sys_sched_setattr() converts that
> error to -EFAULT. This patch fixes the behavior.
> 
> [1] http://thread.gmane.org/gmane.linux.kernel/1615615/focus=1697760
> 
> Signed-off-by: Michael Kerrisk <mtk.manpages@...il.com>
> ---
>  kernel/sched/core.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/kernel/sched/core.c b/kernel/sched/core.c
> index 268a45e..6c9ce28 100644
> --- a/kernel/sched/core.c
> +++ b/kernel/sched/core.c
> @@ -3650,8 +3650,9 @@ SYSCALL_DEFINE3(sched_setattr, pid_t, pid, struct sched_attr __user *, uattr,
>  	if (!uattr || pid < 0 || flags)
>  		return -EINVAL;
>  
> -	if (sched_copy_attr(uattr, &attr))
> -		return -EFAULT;
> +	retval = sched_copy_attr(uattr, &attr);
> +	if (retval)
> +		return retval;
>  
>  	rcu_read_lock();
>  	retval = -ESRCH;
> 


-- 
Michael Kerrisk
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
Linux/UNIX System Programming Training: http://man7.org/training/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/