linux-kernel - Re: [PATCH] net: Use a more standard macro for INET_ADDR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 14 May 2014 16:08:45 -0400 (EDT)
From:	David Miller <davem@...hat.com>
To:	joe@...ches.com
Cc:	netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: Use a more standard macro for INET_ADDR_COOKIE

From: Joe Perches <joe@...ches.com>
Date: Tue, 13 May 2014 20:30:07 -0700

> Missing a colon on definition use is a bit odd so
> change the macro for the 32 bit case to declare an
> __attribute__((unused)) and __deprecated variable.
> 
> The __deprecated attribute will cause gcc to emit
> an error if the variable is actually used.
> 
> Signed-off-by: Joe Perches <joe@...ches.com>

This is fine, applied, thanks Joe.

Perhaps it would have been nicer to make the macros be initializers,
so that it still would look like a proper variable declaration at
the use sites:

	const __addrpair var = INET_ADDR_COOKIE(x, y, z);

or something like that.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/