linux-kernel - Re: mm: hangs in collapse_huge

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140514212915.GB15970@node.dhcp.inet.fi>
Date:	Thu, 15 May 2014 00:29:15 +0300
From:	"Kirill A. Shutemov" <kirill@...temov.name>
To:	Sasha Levin <sasha.levin@...cle.com>
Cc:	Andrea Arcangeli <aarcange@...hat.com>,
	"linux-mm@...ck.org" <linux-mm@...ck.org>,
	LKML <linux-kernel@...r.kernel.org>,
	Dave Jones <davej@...hat.com>,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: mm: hangs in collapse_huge_page

On Sat, May 10, 2014 at 08:34:40PM -0400, Sasha Levin wrote:
> On 04/30/2014 11:42 AM, Kirill A. Shutemov wrote:
> > Sasha, please try patch below.
> 
> That patch really solved the problem for me, I didn't see a single hang
> up until today. So I suspect that while that patch is good there is another
> (smaller) case which may case a hang.

Looks like my patch didn't fix the problem but hide it. Most like due some
shift in timings because of additional lock/unlock.

I'll try to look more for a real issue.

> 
> [ 6006.253399] INFO: task khugepaged:3814 blocked for more than 1200 seconds.
> [ 6006.254711]       Tainted: G        W     3.15.0-rc4-next-20140508-sasha-00020-gec9304b-dirty #452
> [ 6006.257591] "echo 0 > /proc/sys/kernel/hung_task_timeout_secs" disables this message.
> [ 6006.260710] khugepaged      D ffff8805bb7a64b8  4968  3814      2 0x00000000
> [ 6006.263261]  ffff880291e61b48 0000000000000002 ffffffff955890d0 ffff8802927f0000
> [ 6006.264986]  ffff880291e61fd8 00000000001d7840 00000000001d7840 00000000001d7840
> [ 6006.265923]  ffff8805b040b000 ffff8802927f0000 ffff880291e61b38 ffff8802927f0000
> [ 6006.267193] Call Trace:
> [ 6006.267629] ? _raw_spin_unlock_irq (arch/x86/include/asm/paravirt.h:819 include/linux/spinlock_api_smp.h:168 kernel/locking/spinlock.c:199)
> [ 6006.268673] schedule (kernel/sched/core.c:2765)
> [ 6006.269674] rwsem_down_write_failed (kernel/locking/rwsem-xadd.c:289)
> [ 6006.270998] ? get_parent_ip (kernel/sched/core.c:2485)
> [ 6006.271984] call_rwsem_down_write_failed (arch/x86/lib/rwsem.S:106)
> [ 6006.273240] ? khugepaged_scan_mm_slot (mm/huge_memory.c:1991 mm/huge_memory.c:2598)
> [ 6006.274327] ? lock_contended (kernel/locking/lockdep.c:3734 kernel/locking/lockdep.c:3812)
> [ 6006.275299] ? down_write (kernel/locking/rwsem.c:50 (discriminator 2))
> [ 6006.276126] ? collapse_huge_page.isra.31 (mm/huge_memory.c:1991 mm/huge_memory.c:2385)
> [ 6006.277281] collapse_huge_page.isra.31 (mm/huge_memory.c:1991 mm/huge_memory.c:2385)
> [ 6006.278328] ? debug_smp_processor_id (lib/smp_processor_id.c:57)
> [ 6006.279534] ? put_lock_stats.isra.12 (arch/x86/include/asm/preempt.h:98 kernel/locking/lockdep.c:254)
> [ 6006.281314] ? khugepaged_scan_mm_slot (include/linux/spinlock.h:343 mm/huge_memory.c:2540 mm/huge_memory.c:2636)
> [ 6006.282140] ? get_parent_ip (kernel/sched/core.c:2485)
> [ 6006.283039] khugepaged_scan_mm_slot (mm/huge_memory.c:2640)
> [ 6006.284074] khugepaged (include/linux/spinlock.h:343 mm/huge_memory.c:2720 mm/huge_memory.c:2753)
> [ 6006.284986] ? bit_waitqueue (kernel/sched/wait.c:291)
> [ 6006.285864] ? khugepaged_scan_mm_slot (mm/huge_memory.c:2746)
> [ 6006.286897] kthread (kernel/kthread.c:210)
> [ 6006.287705] ? kthread_create_on_node (kernel/kthread.c:176)
> [ 6006.288796] ret_from_fork (arch/x86/kernel/entry_64.S:553)
> [ 6006.289668] ? kthread_create_on_node (kernel/kthread.c:176)
> [ 6006.291708] 1 lock held by khugepaged/3814:
> [ 6006.292368] #0: (&mm->mmap_sem){++++++}, at: collapse_huge_page.isra.31 (mm/huge_memory.c:1991 mm/huge_memory.c:2385)
> 
> 
> Thanks,
> Sasha
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/

-- 
 Kirill A. Shutemov
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/