linux-kernel - Re: [PATCH 2/2] fs: print a message when freezing/unfreezing filesystems

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140514215457.GC5421@dastard>
Date:	Thu, 15 May 2014 07:54:57 +1000
From:	Dave Chinner <david@...morbit.com>
To:	Mateusz Guzik <mguzik@...hat.com>
Cc:	linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org,
	Josef Bacik <jbacik@...com>, Jan Kara <jack@...e.cz>,
	Al Viro <viro@...IV.linux.org.uk>,
	Eric Sandeen <esandeen@...hat.com>
Subject: Re: [PATCH 2/2] fs: print a message when freezing/unfreezing
 filesystems

On Tue, May 13, 2014 at 08:31:02PM +0200, Mateusz Guzik wrote:
> This helps hang troubleshooting efforts when only dmesg is available.

I really don't think that spamming dmesg every time a filesystem is
frozen or thawed is a good idea. This happens a *lot* when systems
are using snapshots, and for the most part nobody cares about
freeze/thaw cycles because they almost always work just fine.

I'd think that /proc/self/mounts would be a much better place to
indicate that the fs is frozen. After all, that's where we tell
people whether the filesystem is ro or rw, and frozen is just
a temporary, non-invasive ro state...

Cheers,

Dave.
-- 
Dave Chinner
david@...morbit.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/