linux-kernel - Re: [PATCH] drivers: staging: line6: Add blank lines after declarations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140515184139.GA28806@gmail.com>
Date:	Thu, 15 May 2014 21:41:39 +0300
From:	rtm <wwctrsrx@...il.com>
To:	Greg KH <gregkh@...uxfoundation.org>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drivers: staging: line6: Add blank lines after
 declarations

On Tue, May 13, 2014 at 02:02:01PM +0200, Greg KH wrote:
> On Wed, May 14, 2014 at 02:56:42AM +0300, Artem Fetishev wrote:
> > Use the more common kernel coding style.
> > 
> > Signed-off-by: Artem Fetishev <wwctrsrx@...il.com>
> > ---
> >  drivers/staging/line6/capture.c  |    4 ++++
> >  drivers/staging/line6/midi.c     |    2 ++
> >  drivers/staging/line6/playback.c |    5 +++++
> >  drivers/staging/line6/pod.c      |    5 +++++
> >  drivers/staging/line6/toneport.c |    2 ++
> >  drivers/staging/line6/variax.c   |    2 ++
> >  6 files changed, 20 insertions(+)
> > 
> > diff --git a/drivers/staging/line6/capture.c b/drivers/staging/line6/capture.c
> > index 0eda51d..14ed0d7 100644
> > --- a/drivers/staging/line6/capture.c
> > +++ b/drivers/staging/line6/capture.c
> > @@ -97,6 +97,7 @@ void line6_unlink_audio_in_urbs(struct snd_line6_pcm *line6pcm)
> >  		if (test_bit(i, &line6pcm->active_urb_in)) {
> >  			if (!test_and_set_bit(i, &line6pcm->unlink_urb_in)) {
> >  				struct urb *u = line6pcm->urb_audio_in[i];
> > +
> >  				usb_unlink_urb(u);
> >  			}
> >  		}
> > @@ -122,6 +123,7 @@ void line6_wait_clear_audio_in_urbs(struct snd_line6_pcm *line6pcm)
> >  		if (!alive)
> >  			break;
> >  		set_current_state(TASK_UNINTERRUPTIBLE);
> > +
> >  		schedule_timeout(1);
> >  	} while (--timeout > 0);
> >  	if (alive)
> 
> That line doesn't look like it needs to be added, why do so?
> 

I've removed that new line in v2 of the patch. I sent it two days ago.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/