linux-kernel - Re: [PATCH] perf session: Fix possible null pointer dereference in session.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140515074440.GA1101@krava.brq.redhat.com>
Date:	Thu, 15 May 2014 09:44:40 +0200
From:	Jiri Olsa <jolsa@...hat.com>
To:	Masanari Iida <standby24x7@...il.com>
Cc:	a.p.zijlstra@...llo.nl, paulus@...ba.org, acme@...nel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] perf session: Fix possible null pointer dereference in
 session.c

On Thu, May 15, 2014 at 02:13:38AM +0900, Masanari Iida wrote:
> cppcheck detected following warning.
> [tools/perf/util/session.c:1628] -> [tools/perf/util/session.c:1632]:
>  (warning) Possible null pointer dereference: session - otherwise it
>  is redundant to check it against null.
> 
> In order to avoide null pointer, check the pointer before use.
> 
> Signed-off-by: Masanari Iida <standby24x7@...il.com>

applied, thanks

jirka

> ---
>  tools/perf/util/session.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/tools/perf/util/session.c b/tools/perf/util/session.c
> index 55960f2..64a186e 100644
> --- a/tools/perf/util/session.c
> +++ b/tools/perf/util/session.c
> @@ -1625,13 +1625,14 @@ out_delete_map:
>  void perf_session__fprintf_info(struct perf_session *session, FILE *fp,
>  				bool full)
>  {
> -	int fd = perf_data_file__fd(session->file);
>  	struct stat st;
> -	int ret;
> +	int fd, ret;
>  
>  	if (session == NULL || fp == NULL)
>  		return;
>  
> +	fd = perf_data_file__fd(session->file);
> +
>  	ret = fstat(fd, &st);
>  	if (ret == -1)
>  		return;
> -- 
> 2.0.0.rc3.2.g998f840
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/