lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 15 May 2014 06:37:26 -0400 (EDT) From: Mikulas Patocka <mpatocka@...hat.com> To: Viresh Kumar <viresh.kumar@...aro.org> cc: "cpufreq@...r.kernel.org" <cpufreq@...r.kernel.org>, Linux Kernel Mailing List <linux-kernel@...r.kernel.org>, "Rafael J. Wysocki" <rjw@...ysocki.net>, "linux-pm@...r.kernel.org" <linux-pm@...r.kernel.org> Subject: Format of patches (was: [PATCH 1/2] speedstep-smi: enable interrupts when waiting) On Thu, 15 May 2014, Viresh Kumar wrote: > On 14 May 2014 19:54, Mikulas Patocka <mpatocka@...hat.com> wrote: > > Hi Viresh > > > > Some times ago, I sent these two cpufreq patches to fix frequency > > transition problem on speedstep-smi, but you didn't put them to the > > upstream kernel. I am resending the patches. If you would like a different > > solution to this problem, please explain it. > > Probably these are just missed by Rafael. The patches are fine but the > above paragraph you wrote would get into kernel logs and must have > been placed below the three dash lines: "---" I used "---" in the past, but some people complained that their script picks the text above "---" and ignores the text below "---" - thus, it does exactly the opposite of what it should do. I don't know what kind of delimiter should I use. Suppose that I want to send something like this: Hi, here I'm sending some cool stuff. *** The message that goes to git. Signed-off-by: Mikulas Patocka <mpatocka@...hat.com> --- drivers/cpufreq/speedstep-lib.c | 3 +++ drivers/cpufreq/speedstep-smi.c | 12 ++++++++++++ 2 files changed, 15 insertions(+) Index: linux-3.14-rc1/drivers/cpufreq/speedstep-smi.c =================================================================== --- linux-3.14-rc1.orig/drivers/cpufreq/speedstep-smi.c 2014-02-03 18:56:44.000000000 +0100 +++ linux-3.14-rc1/drivers/cpufreq/speedstep-smi.c 2014-02-03 19:06:21.000000000 +0100 ... the patch. Now - I'm asking - what kind of barrier should I use between "Hi, here I'm sending some cool stuff" and "The message that goes to git"? I don't really know. The file Documentation/SubmittingPatches doesn't explain it, it says that the message for git should go at the top of the email. If I want the person who receives the patch to read "Hi, here I'm sending some cool stuff" first, I need to put it at the beginning of the email. Maybe we should define a new barrier for this purpose, put it to Documentation/SubmittingPatches and update the scripts? Mikulas -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists