linux-kernel - Re: [PATCH] drm: Missed clflushopt in drm_clflush_virt_range

Open Source and information security mailing list archives

Message-ID: <20140515123846.GQ8790@phenom.ffwll.local>
Date:	Thu, 15 May 2014 14:38:47 +0200
From:	Daniel Vetter <daniel@...ll.ch>
To:	Ross Zwisler <ross.zwisler@...ux.intel.com>
Cc:	linux-kernel@...r.kernel.org, dri-devel@...ts.freedesktop.org,
	Ingo Molnar <mingo@...nel.org>,
	H Peter Anvin <h.peter.anvin@...el.com>,
	Thomas Gleixner <tglx@...utronix.de>
Subject: Re: [PATCH] drm: Missed clflushopt in drm_clflush_virt_range

On Wed, May 14, 2014 at 09:41:12AM -0600, Ross Zwisler wrote:
> With this commit:
> 
> 2a0788dc9bc4 x86: Use clflushopt in drm_clflush_virt_range
> 
> If clflushopt is available on the system, we use it instead of clflush
> in drm_clflush_virt_range.  There were two calls to clflush in this
> function, but only one was changed to clflushopt.  This patch changes
> the other clflush call to clflushopt.
> 
> Signed-off-by: Ross Zwisler <ross.zwisler@...ux.intel.com>
> Reported-by: Matthew Wilcox <matthew.r.wilcox@...el.com>
> 
> Cc: David Airlie <airlied@...ux.ie>
> Cc: dri-devel@...ts.freedesktop.org
> Cc: H Peter Anvin <h.peter.anvin@...el.com>
> Cc: Ingo Molnar <mingo@...nel.org>
> Cc: Thomas Gleixner <tglx@...utronix.de>

Picked to my topic/core-stuff drm branch so it doesn't get lost.
-Daniel

> 
> ---
>  drivers/gpu/drm/drm_cache.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/drm_cache.c b/drivers/gpu/drm/drm_cache.c
> index 534cb89..041b73b 100644
> --- a/drivers/gpu/drm/drm_cache.c
> +++ b/drivers/gpu/drm/drm_cache.c
> @@ -138,7 +138,7 @@ drm_clflush_virt_range(char *addr, unsigned long length)
>  		char *end = addr + length;
>  		mb();
>  		for (; addr < end; addr += boot_cpu_data.x86_clflush_size)
> -			clflush(addr);
> +			clflushopt(addr);
>  		clflushopt(end - 1);
>  		mb();
>  		return;
> -- 
> 1.9.0
> 
> _______________________________________________
> dri-devel mailing list
> dri-devel@...ts.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel

-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives