linux-kernel - Re: WARN in do_rt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140515180409.GA5972@redhat.com>
Date:	Thu, 15 May 2014 20:04:09 +0200
From:	Oleg Nesterov <oleg@...hat.com>
To:	Mateusz Guzik <mguzik@...hat.com>
Cc:	Dave Jones <davej@...hat.com>,
	Peter Zijlstra <peterz@...radead.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	linux-kernel@...r.kernel.org
Subject: Re: WARN in do_rt_tgsigqueueinfo()

On 05/15, Mateusz Guzik wrote:
>
> On Thu, May 15, 2014 at 11:54:15AM -0400, Dave Jones wrote:
> >
> > I'm of the opinion that a user-triggerable WARN is a bug, but aparently
> > not everyone else feels that way.

I didn't really like this WARN_ONCE() when I looked at the patch which
added it, but I didn't try to argue.

> imho warning sysadmins about userspace using deprecated stuff is fine as
> long as users are not able to spam the console with it.

Agreed,

> Warning reported here just looks scary and provides no information for
> sysadmins so I guess it hould be changed.

Again, agreed.

So imo we should either remove it, ot turn it into

	pr_warn_once("something meaningful");

Oleg.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/