linux-kernel - Re: [PATCH] amba: Put the device's of

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 15 May 2014 13:57:04 -0500
From:	Rob Herring <robherring2@...il.com>
To:	Pawel Moll <pawel.moll@....com>
Cc:	Russell King <linux@....linux.org.uk>,
	Rob Herring <robh+dt@...nel.org>,
	Grant Likely <grant.likely@...aro.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>
Subject: Re: [PATCH] amba: Put the device's of_node on its release

On Thu, May 15, 2014 at 12:07 PM, Pawel Moll <pawel.moll@....com> wrote:
> An amba device created from Device Tree, when released, does not
> decrease of_node's reference counter.
>
> Fixed by adding a call to of_device_node_put() on the release
> path, in a similar way to what platform_device_release() is doing.
>
> Signed-off-by: Pawel Moll <pawel.moll@....com>

Acked-by: Rob Herring <robh@...nel.org>

Does this go with the rest of your series? Who needs to pick this up?

Rob

> ---
>  drivers/amba/bus.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/drivers/amba/bus.c b/drivers/amba/bus.c
> index 3cf61a1..0f489fb 100644
> --- a/drivers/amba/bus.c
> +++ b/drivers/amba/bus.c
> @@ -17,6 +17,7 @@
>  #include <linux/pm_runtime.h>
>  #include <linux/amba/bus.h>
>  #include <linux/sizes.h>
> +#include <linux/of_device.h>
>
>  #include <asm/irq.h>
>
> @@ -268,6 +269,7 @@ static void amba_device_release(struct device *dev)
>  {
>         struct amba_device *d = to_amba_device(dev);
>
> +       of_device_node_put(dev);
>         if (d->res.parent)
>                 release_resource(&d->res);
>         kfree(d);
> --
> 1.9.1
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/