linux-kernel - Re: [PATCH v5 3/3] CPU hotplug, smp: Flush any pending IPI callbacks before CPU offline

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 15 May 2014 12:36:56 -0700
From:	"Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>
To:	"Srivatsa S. Bhat" <srivatsa.bhat@...ux.vnet.ibm.com>
Cc:	Tejun Heo <tj@...nel.org>, peterz@...radead.org,
	tglx@...utronix.de, mingo@...nel.org, rusty@...tcorp.com.au,
	akpm@...ux-foundation.org, fweisbec@...il.com, hch@...radead.org,
	mgorman@...e.de, riel@...hat.com, bp@...e.de, rostedt@...dmis.org,
	mgalbraith@...e.de, ego@...ux.vnet.ibm.com, oleg@...hat.com,
	rjw@...ysocki.net, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v5 3/3] CPU hotplug, smp: Flush any pending IPI callbacks
 before CPU offline

On Fri, May 16, 2014 at 12:56:11AM +0530, Srivatsa S. Bhat wrote:
> On 05/16/2014 12:49 AM, Tejun Heo wrote:
> > Hello,
> > 
> > On Fri, May 16, 2014 at 12:44:13AM +0530, Srivatsa S. Bhat wrote:
> >>  /*
> >> + * flush_smp_call_function_queue - Flush any pending smp-call-function
> > 
> > Don't we need a blank line here?
> 
> Hmm? That sentence continues on the next line, hence I didn't add any blank
> line there.

Tejun might be wanting this to be a docbook comment, in which case
it also needs "/**" at the beginning of the comment.

							Thanx, Paul

> >> + * callbacks queued on this CPU (including those for which the source CPU's
> >> + * IPIs might not have been received on this CPU yet). This is invoked by a
> >> + * CPU about to go offline, to ensure that all pending IPI functions are run
> >> + * before it goes completely offline.
> >> + *
> >> + * Loop through the call_single_queue and run all the queued functions.
> >> + * Must be called with interrupts disabled.
> >> + */
> > 
> > Other than that, looks good to me.
> > 
> > Reviewed-by: Tejun Heo <tj@...nel.org>
> > 
> 
> Thank you!
> 
> Regards,
> Srivatsa S. Bhat
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/