linux-kernel - Re: [PATCH] ARM: OMAP: remove some dead code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140515194317.GB4752@drone.musicnaut.iki.fi>
Date:	Thu, 15 May 2014 22:43:17 +0300
From:	Aaro Koskinen <aaro.koskinen@....fi>
To:	Paul Bolle <pebolle@...cali.nl>
Cc:	Kevin Hilman <khilman@...prootsystems.com>,
	Tony Lindgren <tony@...mide.com>,
	Russell King <linux@....linux.org.uk>,
	linux-omap@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ARM: OMAP: remove some dead code

On Thu, May 15, 2014 at 09:16:21PM +0200, Paul Bolle wrote:
> A check for CONFIG_CBUS_TAHVO_USB was added in v2.6.17. The related
> Kconfig symbol has never been part of the tree. Remove that check.
> 
> Replace the while (...) loop with a simple if (...) statement, while
> we're at it.
> 
> Signed-off-by: Paul Bolle <pebolle@...cali.nl>

Acked-by: Aaro Koskinen <aaro.koskinen@....fi>

> ---
> Untested, as usual.
> 
> A quick search across the history of the tree suggests CBUS_TAHVO_USB
> was N770 related. Not that this matters much.

Yes, Tahvo USB is only used on Nokia 770 (which is the correct name,
not N770). The driver is nowadays behind TAHVO_USB, but like you said
the old symbol was never part of the mainline so it's OK to delete it.

A.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/