linux-kernel - Re: [PATCH 5/9] perf, tools: Add perf download to download event files v2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140515201045.GD1873@two.firstfloor.org>
Date:	Thu, 15 May 2014 22:10:45 +0200
From:	Andi Kleen <andi@...stfloor.org>
To:	Namhyung Kim <namhyung@...il.com>
Cc:	Andi Kleen <andi@...stfloor.org>, acme@...radead.org,
	linux-kernel@...r.kernel.org, peterz@...radead.org,
	eranian@...gle.com, jolsa@...hat.com,
	Andi Kleen <ak@...ux.intel.com>
Subject: Re: [PATCH 5/9] perf, tools: Add perf download to download event
 files v2

> Could you please extend this script to support curl also?  It seems the
> wget is not installed by default on my system.

I looked at it, but it's a major pain because curl is totally
incompatible. I don't think it's a major burden to install wget?

> > +set -e
> > +
> > +if [ "$1" == "" ] ; then
> > +	S=$(awk '
> > +/^vendor/     		{ V=$3 }
> > +/^model/ && $2 == ":" 	{ M=$3 }
> > +/^cpu family/ 		{ F = $4 }
> 
> Inconsistency in using whitespace..

awk scripts always start at column 0

-Andi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/