linux-kernel - Re: [PATCH] staging/rtl8723au fix sparse warning in os

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140515205739.GE8897@mwanda>
Date:	Thu, 15 May 2014 23:57:39 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	Konrad Zapalowicz <bergo.torino@...il.com>
Cc:	Larry.Finger@...inger.net, devel@...verdev.osuosl.org,
	gregkh@...uxfoundation.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging/rtl8723au fix sparse warning in os_initfs.c

On Thu, May 15, 2014 at 10:43:34PM +0200, Konrad Zapalowicz wrote:
> This commit fixes the following sparse warning:
> 
> drivers/staging/rtl8723au/os_dep/os_intfs.c:
>     - 322:14: warning: restricted __be16 degrades to integer
> 
> Signed-off-by: Konrad Zapalowicz <bergo.torino@...il.com>
> ---
>  drivers/staging/rtl8723au/os_dep/os_intfs.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/rtl8723au/os_dep/os_intfs.c b/drivers/staging/rtl8723au/os_dep/os_intfs.c
> index 57eca7a..31a70af 100644
> --- a/drivers/staging/rtl8723au/os_dep/os_intfs.c
> +++ b/drivers/staging/rtl8723au/os_dep/os_intfs.c
> @@ -319,7 +319,7 @@ u16 rtw_recv_select_queue23a(struct sk_buff *skb)
>  
>  	memcpy(&eth_type, pdata + (ETH_ALEN << 1), 2);
>  	switch (eth_type) {
> -	case htons(ETH_P_IP):
> +	case be16_to_cpu(htons(ETH_P_IP)):

You should be more careful.  This would have just made the code buggy.

Anyway someone already cleaned up this code.  You should be working
against linux-next.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/