linux-kernel - Re: [PATCH] staging: wlan-ng: Fix sparse warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140515215652.GB4642@kroah.com>
Date:	Thu, 15 May 2014 14:56:52 -0700
From:	Greg KH <gregkh@...uxfoundation.org>
To:	code@...nux.com
Cc:	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org,
	Sarath Lakshman <sarathlakshman@...nux.com>
Subject: Re: [PATCH] staging: wlan-ng: Fix sparse warnings

On Sun, Apr 13, 2014 at 10:09:49PM +0530, code@...nux.com wrote:
> From: Sarath Lakshman <sarathlakshman@...nux.com>

This doesn't match your From: line, why?

> 
> Fixed missed declarations for few non-static functions.
> 
> Signed-off-by: Sarath Lakshman <sarathlakshman@...nux.com>
> ---
>  drivers/staging/wlan-ng/cfg80211.c   | 1 +
>  drivers/staging/wlan-ng/prism2mgmt.h | 6 ++++++
>  2 files changed, 7 insertions(+)
> 
> diff --git a/drivers/staging/wlan-ng/cfg80211.c b/drivers/staging/wlan-ng/cfg80211.c
> index f76f95c..662581c 100644
> --- a/drivers/staging/wlan-ng/cfg80211.c
> +++ b/drivers/staging/wlan-ng/cfg80211.c
> @@ -1,4 +1,5 @@
>  /* cfg80211 Interface for prism2_usb module */
> +#include "prism2mgmt.h"
>  
>  
>  /* Prism2 channel/frequency/bitrate declarations */
> diff --git a/drivers/staging/wlan-ng/prism2mgmt.h b/drivers/staging/wlan-ng/prism2mgmt.h
> index 190d390..ad049ad 100644
> --- a/drivers/staging/wlan-ng/prism2mgmt.h
> +++ b/drivers/staging/wlan-ng/prism2mgmt.h
> @@ -60,6 +60,8 @@
>  #ifndef _PRISM2MGMT_H
>  #define _PRISM2MGMT_H
>  
> +#include "hfa384x.h"
> +
>  extern int prism2_reset_holdtime;
>  extern int prism2_reset_settletime;
>  
> @@ -109,4 +111,8 @@ void prism2sta_processing_defer(struct work_struct *data);
>  void prism2sta_commsqual_defer(struct work_struct *data);
>  void prism2sta_commsqual_timer(unsigned long data);
>  
> +void prism2_connect_result(wlandevice_t *wlandev, u8 failed);
> +void prism2_disconnected(wlandevice_t *wlandev);
> +void prism2_roamed(wlandevice_t *wlandev);

What about the existing declarations of these functions?  Shouldn't they
be removed?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/