linux-kernel - Re: [PATCH v2] PM / OPP: discard duplicate OPP additions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <CAKohpomarqCwU6JTpNpTOTd+4A5zwGYFYEbLFDcvAKbVyY9YTg@mail.gmail.com>
Date:	Fri, 16 May 2014 14:17:59 +0530
From:	Viresh Kumar <viresh.kumar@...aro.org>
To:	Chander Kashyap <chander.kashyap@...aro.org>
Cc:	"linux-pm@...r.kernel.org" <linux-pm@...r.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Nishanth Menon <nm@...com>,
	"Rafael J. Wysocki" <rjw@...ysocki.net>,
	Pavel Machek <pavel@....cz>,
	"Brown, Len" <len.brown@...el.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Chander Kashyap <k.chander@...sung.com>,
	Inderpal Singh <inderpal.s@...sung.com>
Subject: Re: [PATCH v2] PM / OPP: discard duplicate OPP additions

On 16 May 2014 14:12, Chander Kashyap <chander.kashyap@...aro.org> wrote:
> On 16 May 2014 13:54, Viresh Kumar <viresh.kumar@...aro.org> wrote:
>> On 16 May 2014 13:43, Chander Kashyap <chander.kashyap@...aro.org> wrote:
>>> From: Chander Kashyap <k.chander@...sung.com>
>>>
>>> It may be possible to unregister and re-register the cpufreq driver.
>>> One such example is arm big-little IKS cpufreq driver. While
>>> re-registering the driver, same OPPs may get added again.
>>>
>>> This patch detects the duplicacy and discards them.
>>
>> Diff looks fine but not the log ofcourse. It doesn't have anything to do with
>> big LITTLE.. Its just a patch to avoid addition of duplicate OPPs..
>>
>
> Big little reference is provided as an example. Nothing much

What I am saying is: "This is not a problem of re-registering drivers
but adding duplicate OPPs and that's what we should emphasize
on in the log". Your log is all focused on how to get re-registering
of a driver working.

>> Also fix spelling mistakes in log..
>>
>> And subject should be:
>> PM / OPP: discard duplicate OPPs
>
> Duplicates are discarded during OPP addition, and subject line indicates that.

I am asking to improve it. Replace:

PM / OPP: discard duplicate OPP additions

with

PM / OPP: discard duplicate OPPs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/