linux-kernel - Re: [PATCH 13/15] sparc: add renameat2 syscall

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJfpegsyE4TCo5VBG2K2q=2hrnDN5kgZ_Qt-KUvwDSfcq1oitA@mail.gmail.com>
Date:	Fri, 16 May 2014 11:09:02 +0200
From:	Miklos Szeredi <miklos@...redi.hu>
To:	David Miller <davem@...emloft.net>
Cc:	Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 13/15] sparc: add renameat2 syscall

On Thu, May 15, 2014 at 6:49 PM, David Miller <davem@...emloft.net> wrote:
> From: Miklos Szeredi <miklos@...redi.hu>
> Date: Thu, 15 May 2014 14:22:33 +0200
>
>> On Fri, Apr 11, 2014 at 12:25 PM, Miklos Szeredi <miklos@...redi.hu> wrote:
>>> From: Miklos Szeredi <mszeredi@...e.cz>
>>>
>>> Signed-off-by: Miklos Szeredi <mszeredi@...e.cz>
>>> Cc: David S. Miller <davem@...emloft.net>
>>
>> David,
>>
>> I'll be sending a batch of patches with arch support for the renameat2
>> syscall to Linus next week.  If you'd like me to send this as well,
>> could you please ACK it?
>
> For the 32-bit compat case on sparc64, you need to add a wrapper to
> sign extend the oldfd and newfd arguments.
>
> This usually occurs in arch/sparc/kernel/sys32.S, probably something
> like:
>
> SIGN2(sys32_renameat2, sys_renameat2, %o0, %o2)
>
> and then you hook up sys32_renameat2 instead of sys_renameat2 in the
> 32-bit compat syscall table in syscall_64.S

Are you sure?  None of the *at() functions (including renameat())  are in there.

Thanks,
Miklos
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/