linux-kernel - Re: [PATCH] HID: rmi: fix masks for x and w

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.LNX.2.00.1405161114290.16459@pobox.suse.cz>
Date:	Fri, 16 May 2014 11:14:40 +0200 (CEST)
From:	Jiri Kosina <jkosina@...e.cz>
To:	Benjamin Tissoires <benjamin.tissoires@...hat.com>
cc:	Andrew Duggan <aduggan@...aptics.com>, linux-input@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] HID: rmi: fix masks for x and w_x data

On Thu, 15 May 2014, Benjamin Tissoires wrote:

> > The F11 data in the HID report contains four bits of data for w_x and the least significant bits
> > of x. Currently only the first three bits are being used which is resulting in small jumps in
> > the position data on the x axis and in the w_x data.
> > 
> > Signed-off-by: Andrew Duggan <aduggan@...aptics.com>
> > ---
> 
> Good catch. I might have considered that 3:0 means 3 bits, not 4. I must
> have been tired while writing it :)
> 
> Reviewed-by: Benjamin Tissoires <benjamin.tissoires@...hat.com>

Applied, thanks.

-- 
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/