linux-kernel - Re: [PATCH 08/20] perf tools: Allow hpp fields to be sort keys

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87a9aikzhi.fsf@sejong.aot.lge.com>
Date:	Fri, 16 May 2014 15:29:45 +0900
From:	Namhyung Kim <namhyung@...il.com>
To:	Jiri Olsa <jolsa@...hat.com>
Cc:	Arnaldo Carvalho de Melo <acme@...nel.org>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Ingo Molnar <mingo@...nel.org>,
	Paul Mackerras <paulus@...ba.org>,
	Namhyung Kim <namhyung.kim@....com>,
	LKML <linux-kernel@...r.kernel.org>,
	David Ahern <dsahern@...il.com>,
	Andi Kleen <andi@...stfloor.org>,
	Don Zickus <dzickus@...hat.com>
Subject: Re: [PATCH 08/20] perf tools: Allow hpp fields to be sort keys

On Thu, 15 May 2014 15:07:28 +0200, Jiri Olsa wrote:
> On Mon, May 12, 2014 at 03:28:41PM +0900, Namhyung Kim wrote:
>> Add overhead{,_sys,_us,_guest_sys,_guest_us}, sample and period sort
>> keys so that they can be selected with --sort/-s option.
>> 
>>   $ perf report -s period,comm --stdio
>>   ...
>>   # Overhead        Period          Command
>>   # ........  ............  ...............
>>   #
>>       47.06%           152          swapper
>>       13.93%            45  qemu-system-arm
>>       12.38%            40         synergys
>>        3.72%            12          firefox
>>        2.48%             8            xchat
>> 
>> Acked-by: Ingo Molnar <mingo@...nel.org>
>> Signed-off-by: Namhyung Kim <namhyung@...nel.org>
>> ---
>>  tools/perf/ui/hist.c   |  9 +++++++--
>>  tools/perf/util/sort.c | 39 +++++++++++++++++++++++++++++++++++++++
>
> no documentation update.. Documentation/perf-report.txt

Will add.

>
> I wonder we want to update report's '-s' option help string.. it's already big ;-)

Right.  What about just listing basic/common keys and description like
"please refer the man page to the complete list." :)

Thanks,
Namhyung
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/