linux-kernel - Re: [PATCH] Staging: gdm72xx: gdm_wimax: Fixed coding style issues.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140516191230.GA13758@kroah.com>
Date:	Fri, 16 May 2014 12:12:30 -0700
From:	Greg KH <gregkh@...uxfoundation.org>
To:	Junsu Shin <jsshin.dev@...il.com>
Cc:	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Staging: gdm72xx: gdm_wimax: Fixed coding style issues.

On Mon, Apr 28, 2014 at 01:50:11PM -0500, Junsu Shin wrote:
> Fixed following coding style issues.
>  - No space is necessary after a cast
>  - Alignment should match open parenthesis
>  - Braces {} should be used on all arms of this statement

You are doing 3 things, so this should be 3 patches at the least.
Remember, one patch per "thing".

> Signed-off-by: Junsu Shin <jsshin.dev@...il.com>x

What is the trailing 'x' for?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/